[prism] Fusion base, reshuffle, cogbk. #27737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
R: @jrmccluskey |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #27737 +/- ##
==========================================
+ Coverage 70.89% 70.91% +0.02%
==========================================
Files 860 860
Lines 104631 104852 +221
==========================================
+ Hits 74173 74358 +185
- Misses 28904 28935 +31
- Partials 1554 1559 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
ping (polite) |
jrmccluskey
reviewed
Jul 31, 2023
Comment on lines
94
to
99
| if len(t.GetOutputs()) != 1 { | ||
| panic("Expected single putput PCollection in reshuffle: " + prototext.Format(t)) | ||
| } | ||
| if len(t.GetOutputs()) != 1 { | ||
| panic("Expected single putput PCollection in reshuffle: " + prototext.Format(t)) | ||
| } |
There was a problem hiding this comment.
Looks like you missed the input check here and didn't update the panic string for each
There was a problem hiding this comment.
lol. putput. Good catch!
aleksandr-dudko
pushed a commit
to aleksandr-dudko/beam
that referenced
this pull request
Aug 1, 2023
* [prism] Fusion base, reshuffle, cogbk. * silence logging, better message * precise reshuffle strategy filtering * Remove leftover comments * remove decommissioned function * fix typos. --------- Co-authored-by: lostluck <[email protected]>
bullet03
pushed a commit
to akvelon/beam
that referenced
this pull request
Aug 11, 2023
* [prism] Fusion base, reshuffle, cogbk. * silence logging, better message * precise reshuffle strategy filtering * Remove leftover comments * remove decommissioned function * fix typos. --------- Co-authored-by: lostluck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to prism for handling reshuffles, and cogbk.
See #27550 and #24789.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.