Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertex AI Model Handler Private Endpoint Support #27696

Merged
merged 6 commits into from
Jul 31, 2023

Conversation

jrmccluskey
Copy link
Contributor

Tightens retry logic to service-side errors and explicit 429s, explicitly handles private Vertex AI endpoints to support request sizes above 1.5 MB, adds some sanity-checking for args to the model handler (largely private + network pairing,) and makes the example pipeline compatible with private endpoints.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

Codecov bot commented Jul 26, 2023

Codecov Report

Merging #27696 (01a5389) into master (d822fc9) will increase coverage by 0.00%.
Report is 49 commits behind head on master.
The diff coverage is 35.29%.

@@           Coverage Diff           @@
##           master   #27696   +/-   ##
=======================================
  Coverage   70.93%   70.94%           
=======================================
  Files         861      861           
  Lines      104807   104821   +14     
=======================================
+ Hits        74344    74363   +19     
+ Misses      28905    28900    -5     
  Partials     1558     1558           
Flag Coverage Δ
python 80.02% <35.29%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...amples/inference/vertex_ai_image_classification.py 0.00% <0.00%> (ø)
...on/apache_beam/ml/inference/vertex_ai_inference.py 44.77% <40.00%> (+1.91%) ⬆️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jrmccluskey
Copy link
Contributor Author

Run Python_PVR_Flink PreCommit

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey
Copy link
Contributor Author

R: @damccorm

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrmccluskey jrmccluskey merged commit e9c81de into apache:master Jul 31, 2023
73 of 74 checks passed
@jrmccluskey jrmccluskey deleted the privateParty branch July 31, 2023 14:20
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Aug 1, 2023
* Vertex AI Model Handler Private Endpoint Support

* linting

* Trailing whitespace

* import order

* Extra context on experiments

* Trailing whitespace
bullet03 pushed a commit to akvelon/beam that referenced this pull request Aug 11, 2023
* Vertex AI Model Handler Private Endpoint Support

* linting

* Trailing whitespace

* import order

* Extra context on experiments

* Trailing whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants