-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Implemented Hugging Face Model Handler #26632
[Python] Implemented Hugging Face Model Handler #26632
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Run Python 3.8 PostCommit |
Run Python 3.11 PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #26632 +/- ##
==========================================
- Coverage 71.22% 70.97% -0.25%
==========================================
Files 862 863 +1
Lines 104674 104811 +137
==========================================
- Hits 74553 74394 -159
- Misses 28573 28869 +296
Partials 1548 1548
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 33 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
sdks/python/apache_beam/examples/inference/huggingface_language_modeling.py
Outdated
Show resolved
Hide resolved
Run Python 3.8 PostCommit |
Run Python 3.11 PostCommit |
@AnandInguva Robert approved the design. Can you take a final look before merging this? |
Run Python 3.8 PostCommit |
Run Python 3.11 PostCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks. Feel free to merge once the tests are green(if they are related to this PR)
Run Python 3.8 PostCommit |
Run Python 3.11 PostCommit |
Run Python 3.11 PostCommit |
Python 3.11 failure is because of #27643 |
Merging this! |
This PR adds a model handler for loading PyTorch and TensorFlow model handler from Hugging Face Hub.
It builds on this Design doc
Example Job on Dataflow with huggingface_language_modeling.py
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.