Refactor Kinesis IO #26117
Merged
Refactor Kinesis IO #26117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning reviewers. If you would like to opt out of this review, comment R: @lukecwik for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
psolomin
force-pushed
the
refactor-kinesis-io
branch
from
15b06c5 to
48439b9
Compare
psolomin
force-pushed
the
refactor-kinesis-io
branch
from
48439b9 to
6d5b5b9
Compare
mosche
reviewed
Apr 11, 2023
There was a problem hiding this comment.
@psolomin Thanks for extracting these changes from #23540, that's very helpful!
This is mostly fine, a few nitpicks / very minor changes, treat those at your own discretion.
Please have a look at my comment regarding wrapExceptions. This isn't needed for the EFO code, let's leave that in the "simplified" client.
...mazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/ShardListingUtils.java
Outdated
Show resolved
Hide resolved
...mazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/ShardListingUtils.java
Outdated
Show resolved
Hide resolved
...mazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/ShardListingUtils.java
Outdated
Show resolved
Hide resolved
.../java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/kinesis/Helpers.java
Outdated
Show resolved
Hide resolved
.../java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/kinesis/Helpers.java
Outdated
Show resolved
Hide resolved
.../java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/kinesis/Helpers.java
Outdated
Show resolved
Hide resolved
- set missing serialVersionUID - add equals & hashcode methods
This will break checkpoints restoration, but it's inevitable to allow dropping of CheckpointGenerator from KinesisSource.
New tests mock less things and verify checkpoint when fetching records.
Things like ExpiredIterator / NPE are never thrown in shard listing
psolomin
force-pushed
the
refactor-kinesis-io
branch
from
7618632 to
25a6af1
Compare
mosche
approved these changes
Apr 11, 2023
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #19967
This change contains refactors which simplify adding support for enhanced fan-out (#23540).
Changes include breaking serialisation compatibility of
KinesisSourcedue to droppedCheckpointGeneratorclasses, e.g. Flink will not be able to restore Beam 2.46.0 savepoints. Runners which (de-)serialize onlyKinesisReaderCheckpoint, will be able to restore their state for KinesisIO. This is done such that affected classes - especiallyKinesisIO.Read- allow further non-breaking evolution.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.