Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT APPROVE; testing purposes only] added test for KMS key #25902

Closed
wants to merge 15 commits into from

Conversation

BjornPrime
Copy link
Contributor

  1. Extended test coverage before replacing storage client in production code.

Addresses #25676.

robertwb and others added 2 commits March 10, 2023 14:46
This is natural as this field is often large and composed of
the concatenation of many small elements, which can lead to
significant performance improvements.
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.
R: @pabloem for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm
Copy link
Contributor

stop reviewer notifications

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: requested by reviewer

liferoad and others added 2 commits March 20, 2023 11:27
* Add one example to learn beam by doing

* add license

* clear the output

* Polished the notebook based on the comments

* cleared out the output

* Changed the answer views

* Update some cells

* Polished the words

* Update examples/notebooks/get-started/learn_beam_basics_by_doing.ipynb

Co-authored-by: tvalentyn <[email protected]>

---------

Co-authored-by: xqhu <[email protected]>
Co-authored-by: tvalentyn <[email protected]>
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #25902 (d7c693a) into master (476c433) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #25902      +/-   ##
==========================================
- Coverage   71.42%   71.38%   -0.04%     
==========================================
  Files         778      779       +1     
  Lines      102379   102341      -38     
==========================================
- Hits        73127    73060      -67     
- Misses      27797    27820      +23     
- Partials     1455     1461       +6     
Flag Coverage Δ
go 53.95% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/gcsio.py 94.94% <ø> (+2.66%) ⬆️
...ks/python/apache_beam/runners/interactive/utils.py 94.97% <ø> (-0.12%) ⬇️
sdks/go/pkg/beam/core/runtime/exec/sdf.go 65.81% <100.00%> (-0.31%) ⬇️
sdks/python/apache_beam/transforms/core.py 93.14% <100.00%> (+0.22%) ⬆️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BjornPrime BjornPrime closed this Mar 24, 2023
@BjornPrime BjornPrime deleted the replace-client-storage branch March 24, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants