Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go SDK minimum Go version to 1.19 #25545

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Update Go SDK minimum Go version to 1.19 #25545

merged 4 commits into from
Feb 17, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Feb 17, 2023

New dependencies have required the Go SDK minimum Go version to be increased to 1.19 at minimum, which is the current trailing stable Go version.

Users are likely already on 1.20 by now, so this largely affects Beam infra, which has also been updated in this PR.

Motivated by coverage failing when run under Go 1.18: https://github.com/apache/beam/actions/runs/4207200414/jobs/7301693353


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@lostluck
Copy link
Contributor Author

R: @damccorm

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #25545 (66f0577) into master (20c8d3a) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25545      +/-   ##
==========================================
- Coverage   72.80%   72.66%   -0.15%     
==========================================
  Files         750      758       +8     
  Lines       99314   100681    +1367     
==========================================
+ Hits        72304    73155     +851     
- Misses      25648    26118     +470     
- Partials     1362     1408      +46     
Flag Coverage Δ
go 52.13% <ø> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/io/mongodbio/read.go 9.03% <0.00%> (-21.94%) ⬇️
sdks/go/pkg/beam/io/mongodbio/coder.go 83.33% <0.00%> (-16.67%) ⬇️
sdks/go/pkg/beam/core/runtime/exec/sdf.go 66.12% <0.00%> (-3.00%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.49% <0.00%> (-0.64%) ⬇️
...ython/apache_beam/io/gcp/bigquery_read_internal.py 57.21% <0.00%> (-0.49%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
sdks/python/apache_beam/io/gcp/bigquery.py 71.11% <0.00%> (-0.24%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.30% <0.00%> (-0.16%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 94.33% <0.00%> (-0.12%) ⬇️
sdks/go/pkg/beam/io/mongodbio/common.go 0.00% <0.00%> (ø)
... and 23 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lostluck lostluck changed the title Update Go SDK version to 1.19 Update Go SDK minimum Go version to 1.19 Feb 17, 2023
@lostluck
Copy link
Contributor Author

Given the breadth of effect, I'm going to wait for the various test runs to complete first.

@lostluck
Copy link
Contributor Author

The last change everything but the go tests passed, and the last change only affected the Go tests.

This should be safe to merge, but I'll keep an eye on the postcommit runs just in case, so we can roll it back promptly.

@lostluck lostluck merged commit 8692026 into master Feb 17, 2023
@lostluck lostluck deleted the updateGo119 branch April 12, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants