-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Go SDK minimum Go version to 1.19 #25545
Conversation
R: @damccorm |
Codecov Report
@@ Coverage Diff @@
## master #25545 +/- ##
==========================================
- Coverage 72.80% 72.66% -0.15%
==========================================
Files 750 758 +8
Lines 99314 100681 +1367
==========================================
+ Hits 72304 73155 +851
- Misses 25648 26118 +470
- Partials 1362 1408 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Given the breadth of effect, I'm going to wait for the various test runs to complete first. |
The last change everything but the go tests passed, and the last change only affected the Go tests. This should be safe to merge, but I'll keep an eye on the postcommit runs just in case, so we can roll it back promptly. |
New dependencies have required the Go SDK minimum Go version to be increased to 1.19 at minimum, which is the current trailing stable Go version.
Users are likely already on 1.20 by now, so this largely affects Beam infra, which has also been updated in this PR.
Motivated by coverage failing when run under Go 1.18: https://github.com/apache/beam/actions/runs/4207200414/jobs/7301693353
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.