Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#24515] Delete the JRH #24967

Merged
merged 3 commits into from
Jan 21, 2023
Merged

[#24515] Delete the JRH #24967

merged 3 commits into from
Jan 21, 2023

Conversation

lukecwik
Copy link
Member

@lukecwik lukecwik commented Jan 10, 2023

Move :runners:google-cloud-dataflow-java:worker:legacy-worker to :runners:google-cloud-dataflow-java:worker deleting the FnApi runner harness (aka JRH) and the code that was powering it.

Towards #25103


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

Move :runners:google-cloud-dataflow-java:worker:legacy-worker to :runners:google-cloud-dataflow-java:worker deleting the FnApi runner harness (aka JRH) and the code that was powering it.

Fixes apache#24515
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #24967 (7a5f2ad) into master (7d6d6de) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24967   +/-   ##
=======================================
  Coverage   73.12%   73.13%           
=======================================
  Files         735      735           
  Lines       98146    98148    +2     
=======================================
+ Hits        71773    71783   +10     
+ Misses      25010    25002    -8     
  Partials     1363     1363           
Flag Coverage Δ
python 82.69% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.08% <0.00%> (-0.17%) ⬇️
...dks/python/apache_beam/options/pipeline_options.py 93.97% <0.00%> (+0.02%) ⬆️
sdks/python/apache_beam/transforms/util.py 96.39% <0.00%> (+0.15%) ⬆️
sdks/python/apache_beam/transforms/combiners.py 93.43% <0.00%> (+0.38%) ⬆️
sdks/python/apache_beam/runners/direct/executor.py 97.01% <0.00%> (+0.54%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 91.77% <0.00%> (+1.26%) ⬆️
...n/apache_beam/ml/gcp/recommendations_ai_test_it.py 75.51% <0.00%> (+2.04%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (+4.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lukecwik
Copy link
Member Author

Run GoPortable PreCommit

@lukecwik
Copy link
Member Author

Run PythonDocs PreCommit

@lukecwik
Copy link
Member Author

Run SQL_Java17 PreCommit

@lukecwik
Copy link
Member Author

Run Python PreCommit

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lukecwik
Copy link
Member Author

whitespace check broken by #24951

@lukecwik
Copy link
Member Author

Run Whitespace PreCommit

@lukecwik
Copy link
Member Author

Run Java_Kafka_IO_Direct PreCommit

@Abacn
Copy link
Contributor

Abacn commented Jan 20, 2023

Run PostCommit_Java_Dataflow

@Abacn
Copy link
Contributor

Abacn commented Jan 20, 2023

Run Java PostCommit

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! this LGTM to the best of my knowledge

Besides Java PostCommit (which also runs zetasketch) there are also load tests, nexmark, tpcds build affected. Will follow up on cron jobs once this is merged.

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relevant postcommit tests passed.
Thanks!

@lukecwik lukecwik merged commit 4dad3c6 into apache:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants