-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure WRITE_TRUNCATE BigQuery loads to the same table are processed together. #24536
Conversation
…together. This fixes apache#24535.
Assigning reviewers. If you would like to opt out of this review, comment R: @pabloem for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
run python precommit |
Run Python 3.7 PostCommit |
self.process_one(element_list) | ||
else: | ||
for element in element_list: | ||
self.process_one(element) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's pass the side inputs into process_one
, this is probably causing the failing tests in https://ci-beam.apache.org/job/beam_PreCommit_Python_Phrase/3289/testReport/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I fixed this, but not it's failing on (unrelated-looking) proto issues. Trying to run tests again...
Codecov Report
@@ Coverage Diff @@
## master #24536 +/- ##
==========================================
+ Coverage 73.37% 73.61% +0.24%
==========================================
Files 719 721 +2
Lines 97209 98318 +1109
==========================================
+ Hits 71323 72380 +1057
- Misses 24538 24590 +52
Partials 1348 1348
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
it looks like proto generation is broken for the python tests |
retest this please |
Setting aside GHA (which I don't know if they could have other sources of instability) the scan at https://scans.gradle.com/s/ivqiu46gmopb6 for the Jenkins run says that |
Run Python PreCommit |
1 similar comment
Run Python PreCommit |
All the Jenkins tests pass, the github actions issues are unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This fixes #24535 and fixes #23306 in a streaming-update compatible way.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.