Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure WRITE_TRUNCATE BigQuery loads to the same table are processed together. #24536

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Dec 5, 2022

This fixes #24535 and fixes #23306 in a streaming-update compatible way.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @pabloem for label python.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@johnjcasey
Copy link
Contributor

run python precommit

@ahmedabu98
Copy link
Contributor

Run Python 3.7 PostCommit

Comment on lines 522 to 525
self.process_one(element_list)
else:
for element in element_list:
self.process_one(element)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pass the side inputs into process_one, this is probably causing the failing tests in https://ci-beam.apache.org/job/beam_PreCommit_Python_Phrase/3289/testReport/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I fixed this, but not it's failing on (unrelated-looking) proto issues. Trying to run tests again...

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #24536 (7ba6866) into master (cb329e4) will increase coverage by 0.24%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master   #24536      +/-   ##
==========================================
+ Coverage   73.37%   73.61%   +0.24%     
==========================================
  Files         719      721       +2     
  Lines       97209    98318    +1109     
==========================================
+ Hits        71323    72380    +1057     
- Misses      24538    24590      +52     
  Partials     1348     1348              
Flag Coverage Δ
python 83.18% <80.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/python/apache_beam/io/gcp/bigquery_file_loads.py 87.16% <80.00%> (-0.25%) ⬇️
sdks/python/apache_beam/typehints/schemas.py 88.07% <0.00%> (-0.89%) ⬇️
...apache_beam/runners/dataflow/internal/apiclient.py 76.72% <0.00%> (-0.63%) ⬇️
...s/python/apache_beam/runners/portability/stager.py 87.04% <0.00%> (-0.18%) ⬇️
...dks/python/apache_beam/options/pipeline_options.py 93.95% <0.00%> (-0.02%) ⬇️
sdks/python/apache_beam/typehints/row_type.py 100.00% <0.00%> (ø)
...s/python/apache_beam/typehints/testing/__init__.py 100.00% <0.00%> (ø)
...python/apache_beam/typehints/testing/strategies.py 100.00% <0.00%> (ø)
...hon/apache_beam/runners/worker/bundle_processor.py 93.67% <0.00%> (+0.12%) ⬆️
sdks/python/apache_beam/runners/direct/executor.py 97.01% <0.00%> (+0.54%) ⬆️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@johnjcasey
Copy link
Contributor

it looks like proto generation is broken for the python tests

@ahmedabu98
Copy link
Contributor

retest this please

@kennknowles
Copy link
Member

Setting aside GHA (which I don't know if they could have other sources of instability) the scan at https://scans.gradle.com/s/ivqiu46gmopb6 for the Jenkins run says that :sdks:python:test-suites:tox:py310:testPy310Cloud failed

@robertwb
Copy link
Contributor Author

robertwb commented Dec 9, 2022

Run Python PreCommit

1 similar comment
@robertwb
Copy link
Contributor Author

Run Python PreCommit

@robertwb
Copy link
Contributor Author

All the Jenkins tests pass, the github actions issues are unrelated.

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertwb robertwb merged commit 7c55f76 into apache:master Dec 20, 2022
lostluck pushed a commit to lostluck/beam that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants