Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted initialNumReaders paramter. #24355

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

AdalbertMemSQL
Copy link
Contributor

@AdalbertMemSQL AdalbertMemSQL commented Nov 25, 2022

Deleted initialNumReaders paramter.
Pre-split restrictions to the maximum number of readers.
See the discussion in the design doc for more details.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

Pre-split restrictions to the maximum number of readers.
See the discussion in the design doc for more details: https://docs.google.com/document/d/1WU-hkoZ93SaGXyOz_UtX0jXzIRl194hCId_IdmEV9jw/edit?disco=AAAAjCSqPvs
@AdalbertMemSQL
Copy link
Contributor Author

addresses #22617

@AdalbertMemSQL
Copy link
Contributor Author

R: @lukecwik

@AdalbertMemSQL
Copy link
Contributor Author

R: @Abacn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@AdalbertMemSQL
Copy link
Contributor Author

R: @johnjcasey

@AdalbertMemSQL AdalbertMemSQL marked this pull request as ready for review November 25, 2022 11:45
@Abacn
Copy link
Contributor

Abacn commented Nov 26, 2022

Run Java SingleStoreIO Performance Test

@Abacn
Copy link
Contributor

Abacn commented Nov 26, 2022

Thanks. Followed the discussion but in case I missed something, could you please summarize the pros/cons of removing this parameter?

@AdalbertMemSQL
Copy link
Contributor Author

Hi @Abacn

Sure.
Pros:

  • it will make configuration easier as users will have fewer parameters
  • the runner will fully control the parallelism and the user won't need to worry about it
    I don't see any cons.

@lukecwik Do you have something to add?

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.

@Abacn
Copy link
Contributor

Abacn commented Nov 30, 2022

okay, let us get this in before release cut to avoid a breaking change in released version

@Abacn Abacn merged commit 3bd76cc into apache:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants