Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add map_windows support to Go SDK #24307

Merged
merged 6 commits into from
Nov 30, 2022
Merged

Add map_windows support to Go SDK #24307

merged 6 commits into from
Nov 30, 2022

Commits on Nov 29, 2022

  1. Add map_windows support to Go SDK 

    Adds support to the Go SDK for the [map_windows][1] urn.

The existing type model does not allow `IntervalWindow` as
a FullValue and the existing coders will throw away the window
values when decoding the KV type [here][2] in `elideSingleElmFV`.
This change updates coder construction to allow an IntervalWindow
as a value coder.

[1]: https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto#L296
[2]: https://github.com/camphillips22/beam/blob/8be4cdcaf65a1e53e3041ac3354e2e99c845e915/sdks/go/pkg/beam/core/runtime/exec/coder.go#L580-L580
    @camphillips22
    camphillips22 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    b3d6c14 View commit details
    Browse the repository at this point in the history

  2. fix

    @camphillips22
    camphillips22 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    93b270f View commit details
    Browse the repository at this point in the history

  3. add test for unit. fix KV coder spec

    @camphillips22
    camphillips22 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    1884490 View commit details
    Browse the repository at this point in the history

  4. no special casing the iw coder

    @camphillips22
    camphillips22 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    bf604de View commit details
    Browse the repository at this point in the history

  5. coder marshaling tests

    @camphillips22
    camphillips22 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    2f24f56 View commit details
    Browse the repository at this point in the history

  6. conflict fixes

    @camphillips22
    camphillips22 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    38931b6 View commit details
    Browse the repository at this point in the history