-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for JsonSchema in Kafka Read Schema Transform #24272
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report
@@ Coverage Diff @@
## master #24272 +/- ##
=======================================
Coverage 73.38% 73.38%
=======================================
Files 719 719
Lines 97206 97206
=======================================
Hits 71335 71335
Misses 24524 24524
Partials 1347 1347
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
Outdated
Show resolved
Hide resolved
67c2b34
to
30574bd
Compare
Reminder, please take a look at this pr: @kennknowles @Abacn @johnjcasey |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @lukecwik for label java. Available commands:
|
stop reviewer notifications |
Stopping reviewer notifications for this pull request: requested by reviewer |
aa6b885
to
60c22aa
Compare
60c22aa
to
6f0a9c3
Compare
Run Java PreCommit |
1c9815c
to
4344539
Compare
r: @ahmedabu98 : ) |
Run Java PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Pablo! I appreciate the Class name changes :) LGTM
* Implement KafkaReadSchemaTransform support for JSON * fixup * add dependencies * fixup
This PR depends on #24271
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.