Adds a Java RunInference example #23619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning reviewers. If you would like to opt out of this review, comment R: @kileys for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
R: @damccorm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
damccorm
reviewed
Oct 14, 2022
chamikaramj
force-pushed
the
runinference_example_sklearn
branch
from
510f324
to
f088110
Compare
|
Thanks. PTAL. I re-uploaded a model that ran on the full input dataset and this generates output correctly. |
damccorm
reviewed
Oct 17, 2022
...es/java/src/main/java/org/apache/beam/examples/multilanguage/SklearnMnistClassification.java
Outdated
Show resolved
Hide resolved
...es/java/src/main/java/org/apache/beam/examples/multilanguage/SklearnMnistClassification.java
Show resolved
Hide resolved
...es/java/src/main/java/org/apache/beam/examples/multilanguage/SklearnMnistClassification.java
Show resolved
Hide resolved
...es/java/src/main/java/org/apache/beam/examples/multilanguage/SklearnMnistClassification.java
Show resolved
Hide resolved
...es/java/src/main/java/org/apache/beam/examples/multilanguage/SklearnMnistClassification.java
Outdated
Show resolved
Hide resolved
...es/java/src/main/java/org/apache/beam/examples/multilanguage/SklearnMnistClassification.java
Outdated
Show resolved
Hide resolved
...es/java/src/main/java/org/apache/beam/examples/multilanguage/SklearnMnistClassification.java
Show resolved
Hide resolved
| @@ -49,7 +49,6 @@ | |||
| * ./gradlew :examples:multi-language:pythonDataframeWordCount --args=" \ | |||
| * --runner=DataflowRunner \ | |||
| * --output=gs://{$OUTPUT_BUCKET}/count \ | |||
| * --experiments=use_runner_v2 \ | |||
There was a problem hiding this comment.
Did you mean to remove this?
There was a problem hiding this comment.
Yeah, we don't need this anymore.
chamikaramj
commented
Oct 17, 2022
...es/java/src/main/java/org/apache/beam/examples/multilanguage/SklearnMnistClassification.java
Show resolved
Hide resolved
| @@ -49,7 +49,6 @@ | |||
| * ./gradlew :examples:multi-language:pythonDataframeWordCount --args=" \ | |||
| * --runner=DataflowRunner \ | |||
| * --output=gs://{$OUTPUT_BUCKET}/count \ | |||
| * --experiments=use_runner_v2 \ | |||
There was a problem hiding this comment.
Yeah, we don't need this anymore.
|
(waiting on test suites to merge, feel free to do so when that happens) |
|
Thanks. All tests are passing. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #22855
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.