-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go SDK] Dataframe API wrapper #23450
Conversation
Should not be merged until after #23383 , tests will likely fail on this PR until then. |
R: @lostluck |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #23450 +/- ##
==========================================
+ Coverage 73.35% 73.44% +0.09%
==========================================
Files 719 718 -1
Lines 95800 95884 +84
==========================================
+ Hits 70276 70424 +148
+ Misses 24212 24149 -63
+ Partials 1312 1311 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
PR #23383 is now merged, so ready for re-testing. I still need to look at the code, but please also add a mention of Dataframes to CHANGES.md |
The
|
For the current PR, filtered the test if |
Run Go PostCommit |
Run XVR_Flink PostCommit |
The error in postcommit is due to the insufficient quota in apache-beam-testing as we saw in earlier PR |
Run Go PostCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment, then I'll merge this in. Thanks for your patience!
Don't forget to resolve the CHANGES.md conflicts too. |
Wrapped Dataframe API with integration test. This needs beam python container later than 2.41.0 (because it needs
RowsToDataFrameFn
internally which was added after 2.41.0) so tested it with 2.42.0rc1.Closes #23384
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.