Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a ClassLoadingStrategy that is compatible with Java 17+ #23055

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Sep 6, 2022

See "Supporting proxies on Java versions prior to 9 and past 10" in http://mydailyjava.blogspot.com/2018/04/jdk-11-and-proxies-in-world-past.html


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the java label Sep 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@cushon
Copy link
Contributor Author

cushon commented Sep 7, 2022

R: @kileys

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@kileys
Copy link
Contributor

kileys commented Sep 7, 2022

Run Java PreCommit

@kileys
Copy link
Contributor

kileys commented Sep 7, 2022

Run Java Dataflow V2 ValidatesRunner

@kileys
Copy link
Contributor

kileys commented Sep 7, 2022

Run Dataflow ValidatesRunner Java 17

@kileys
Copy link
Contributor

kileys commented Sep 7, 2022

Run Dataflow ValidatesRunner Java 11

@kileys
Copy link
Contributor

kileys commented Sep 7, 2022

@kileys
Copy link
Contributor

kileys commented Sep 8, 2022

Run Java PreCommit

1 similar comment
@kileys
Copy link
Contributor

kileys commented Sep 8, 2022

Run Java PreCommit

@kileys kileys merged commit ef0bb6d into apache:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants