Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move standard and common logical type implementations into separate module #22992

Closed
wants to merge 2 commits into from

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Sep 1, 2022

In preparation of #19817 where more logical types will be introduced.

This is also in alignment with Java SDK where known logical types are defined in org.apache.beam.sdk.schemas.logicaltypes package.

Due to a bug that causes registered logical types cannot be imported that is fixed recently (#22561 (comment)), this effectively not introducing break changes to released versions.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #22992 (236cb6c) into master (32964e1) will increase coverage by 0.01%.
The diff coverage is 94.64%.

@@            Coverage Diff             @@
##           master   #22992      +/-   ##
==========================================
+ Coverage   73.68%   73.69%   +0.01%     
==========================================
  Files         713      715       +2     
  Lines       94988    95166     +178     
==========================================
+ Hits        69992    70133     +141     
- Misses      23695    23732      +37     
  Partials     1301     1301              
Flag Coverage Δ
python 83.49% <94.64%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/typehints/logical_types.py 94.54% <94.54%> (ø)
sdks/python/apache_beam/typehints/schemas.py 93.84% <100.00%> (-0.01%) ⬇️
sdks/python/apache_beam/typehints/__init__.py 77.77% <0.00%> (-22.23%) ⬇️
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
.../apache_beam/runners/interactive/dataproc/types.py 93.10% <0.00%> (-3.45%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) ⬇️
sdks/python/apache_beam/dataframe/schemas.py 96.62% <0.00%> (-1.05%) ⬇️
...hon/apache_beam/runners/direct/test_stream_impl.py 93.28% <0.00%> (-0.75%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 77.53% <0.00%> (-0.73%) ⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abacn
Copy link
Contributor Author

Abacn commented Sep 1, 2022

Run Python 3.8 PostCommit

@Abacn
Copy link
Contributor Author

Abacn commented Sep 1, 2022

Not going to work because logical_types depends on schemas.logical_type, will still need to import them at the bottom of schemas.py

@Abacn Abacn closed this Sep 1, 2022
@Abacn Abacn deleted the logicaltypesmodule branch September 1, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant