Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Update case-studies logo images #22793

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

bullet03
Copy link
Contributor

@bullet03 bullet03 commented Aug 19, 2022

Resolves #22799

  • change css prop from width to max-width to fit logos with rectangle images, so it wouldn't stretch too much (Intuit, Paloalto, Ricardo, Seznam case-studies)
  • add case-study-opinion-img-center class to center logos with narrow images (Hop, Lyft case-studies)

before:
before_logos
after:
after_logos
after_2
after_3

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@bullet03 bullet03 force-pushed the website-update-case-studies-logo branch from aff8441 to c8cd725 Compare August 19, 2022 15:38
@alevtinaboiko
Copy link

Verified, works as expected. Reviewed and tested by QA

@bullet03 bullet03 marked this pull request as ready for review August 22, 2022 16:25
@bullet03
Copy link
Contributor Author

@pcoet, could you, please, help with review of current PR?

@bullet03
Copy link
Contributor Author

@pabloem, could you, please, help with merging?

@bullet03
Copy link
Contributor Author

bullet03 commented Sep 9, 2022

@aromanenko-dev, could you kindly help with merge? PR was approved.

@pabloem
Copy link
Member

pabloem commented Sep 9, 2022

my apologies

@pabloem pabloem merged commit ec4aaa4 into apache:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Case studies logos stretching too much on mobile resolutions
4 participants