-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override log levels after log handler is created #22191
Conversation
* This fixes error message about log level overrides not shown when executed with Dataflow runner
Codecov Report
@@ Coverage Diff @@
## master #22191 +/- ##
==========================================
+ Coverage 74.21% 74.24% +0.02%
==========================================
Files 702 702
Lines 92829 92962 +133
==========================================
+ Hits 68892 69018 +126
- Misses 22670 22677 +7
Partials 1267 1267
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Tested on dataflow runner v2. Invalid log overrides option now has the following log message (at the very beginning of worker log):
Using a valid option (e.g. R: @tvalentyn |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Would it be possible to add a test that fails without this change? |
fix ghost "NoneType" in default level error message
retest this please |
Addressed. please take another look, thanks! |
Fix method name typos Co-authored-by: tvalentyn <[email protected]>
Co-authored-by: tvalentyn <[email protected]>
Follow up of #18222
executed with Dataflow runner
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.