Add ability to self-assign issues for non-committers #21719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
R: @lostluck |
This was referenced Jun 6, 2022
lostluck
approved these changes
Jun 8, 2022
|
LGTM |
This was referenced Jun 8, 2022
aaltay
reviewed
Jun 8, 2022
| 2. Comment ".take-issue" on the issue. This will cause the issue to be assigned to you. | ||
| When you've completed the issue, you can close it by commenting ".close-issue". | ||
| If you are a committer and would like to assign an issue to a non-committer, they must comment | ||
| on the issue first; please tag the user asking them to do so or to comment ".take-issue". |
There was a problem hiding this comment.
How would a committer ask non-committers to comment ".take-issue", without it causing the issue to be assigned to the committer?
There was a problem hiding this comment.
That's a good point - that's a limitation as currently implemented.
I added #21755 to address that limitation, it will ignore comments like .take-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, non-committers can't self assign issues - this allows them to do so by commenting .take-issue.
Example of this working - damccorm/playground#3
Addresses #21684
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.