[BEAM-8399] Add --hdfs_full_urls option #10223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhitaoli
reviewed
Dec 4, 2019
zhitaoli
reviewed
Dec 4, 2019
zhitaoli
reviewed
Dec 4, 2019
zhitaoli
reviewed
Dec 4, 2019
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
ping? is it possible to get this proper merged? |
Fully @parameterized unit tests to use/not use full URLs. Added integration test with --full_urls. parameterized min version increased for parameterized_class decorator.
udim
changed the title
zhitaoli
approved these changes
Feb 10, 2020
|
Run Portable_Python PreCommit |
|
Run PythonLint PreCommit |
|
Run PythonFormatter PreCommit |
1 similar comment
|
Run PythonFormatter PreCommit |
|
Run Python PreCommit |
1 similar comment
|
Run Python PreCommit |
|
Run Python PreCommit |
|
Run Python PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new mode, enabled via
--hdfs_full_urls.In this mode, all hdfs:// URLs are expected to have a server designation in the first path element:
The server part is ignored; the connection config still comes from these flags:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.