Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: fastjson & fastjson2 dependencies #24154

Closed
gabry-lab opened this issue Nov 14, 2022 · 5 comments · Fixed by #28007
Closed

[Feature Request]: fastjson & fastjson2 dependencies #24154

gabry-lab opened this issue Nov 14, 2022 · 5 comments · Fixed by #28007

Comments

@gabry-lab
Copy link
Member

gabry-lab commented Nov 14, 2022

What would you like to happen?

I find that beam is using jackson and fastjson at the same time, why not remove fastjson? I think jackson is enough to parse a json object

Issue Priority

Priority: 2

Issue Component

Component: dsl-sql

beam version

2.34.0

@gabry-lab gabry-lab changed the title [Feature Request]: remove fastjson & fastjson2 dependencies [Feature Request]: fastjson & fastjson2 dependencies Nov 14, 2022
@kennknowles
Copy link
Member

Good point. I see also that fastjson is added separately to many modules, which could cause some dependency issues.

It goes all the way back to aff736f which was part of migration to Gradle build in #4096. I did not go further back to try to find out what was happening in the pom.xml

CC @kileys @apilloud

@apilloud
Copy link
Member

This appears to be a duplicate of #20167?

@gabry-lab
Copy link
Member Author

separately to many modules

Yes, it is. @kennknowles If it's OK, I'll create a PR to remove it.

@apilloud
Copy link
Member

Yes, please fix. I'd be happy to review your change.

@gabry-lab
Copy link
Member Author

Yes, please fix. I'd be happy to review your change.

@apilloud can you help to review this PR? #28007

@github-actions github-actions bot added this to the 2.51.0 Release milestone Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants