Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dataflow v1 Python 3.10 tests, once the runner supports it. #21971

Closed
AnandInguva opened this issue Jun 22, 2022 · 2 comments
Closed

Add Dataflow v1 Python 3.10 tests, once the runner supports it. #21971

AnandInguva opened this issue Jun 22, 2022 · 2 comments
Assignees
Labels
core done & done Issue has been reviewed after it was closed for verification, followups, etc. P2 python task

Comments

@AnandInguva
Copy link
Contributor

What needs to happen?

Once the legacy Dataflow supports Python 3.10, add the Dataflow python 3.10 tests.

Issue Priority

Priority: 2

Issue Component

Component: sdk-py-core

@AnandInguva
Copy link
Contributor Author

.take-issue

AnandInguva added a commit to AnandInguva/beam that referenced this issue Jul 27, 2022
@github-actions github-actions bot added the stale label Aug 21, 2022
AnandInguva added a commit to AnandInguva/beam that referenced this issue Oct 11, 2022
* Update Pytest version to support Python 3.10

* Update pytest-cov

* update dependencies with updated pytest related changes

* set upToDateWhen = false

* add 3.10 to tox and pytest

* Change float to string for python versions

* Add python 3.10 container

update python 3.10 dependencies

* Add precommit and postcommit changes

apache#21971

* Add Python 3.10 build file to the test suites

* Update tox with python 3.10 and add python 3.10 test suites to settings.gradle.kts

* Add InferencePostCommit to Py310 from Py39

* Change jump offset multiplier

* Add GEN_START

* Update comment

* add tox test suite

* Fix NewType and NamedTuple (#3)

* Remove unified repr (#4)

* Fix NewType and NamedTuple

* Fix names in unit tests

* Remove commented out code (#5)

* Fix more failing tests (#6)

* Remove commented out code

* Fix other tests

* fixup assertion

* resolve merge conflicts

* Add Python 3.10 to Dataflow supported version. Sickbay runner v1 tests

* Remove Python 3.10 warning

* Fixup test

* Enable additional Dataflow  test suites

* Update dependencies

* Add Python 3.10 to GH actions tests

* Add Python 3.10 to some dataflow test-suites

* Unskip tests that were sickbayed for runner_v1

* Update pandas dep for Python 3.10

* Fixup: typo

* generate dependencies

* pin protobuf requirement

* pin grpcio version

* Revert "pin grpcio version"

This reverts commit 82f9bbb.

* Revert "pin protobuf requirement"

This reverts commit 00e5b98.

* install protobuf from source

* Revert "install protobuf from source"

This reverts commit 2aa434a.

* Pin Protobuf to 3.19.4

Co-authored-by: Anand Inguva <[email protected]>
Co-authored-by: Andy Ye <[email protected]>
AnandInguva added a commit to AnandInguva/beam that referenced this issue Oct 11, 2022
@damccorm damccorm removed the stale label Dec 2, 2022
@AnandInguva
Copy link
Contributor Author

@tvalentyn I think we can close this issue assuming we are not supporting Dataflow Runner v1 from Python versions 3.10+

@tvalentyn tvalentyn added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Apr 12, 2023
@github-actions github-actions bot added this to the 2.48.0 Release milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core done & done Issue has been reviewed after it was closed for verification, followups, etc. P2 python task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants