snippetEditingControllerGetter refinement (#24617)

apache · Jan 19, 2023 · d261b2a · d261b2a
1 parent 93798ea
commit d261b2a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/playground/frontend/playground_components/lib/src/controllers/code_runner.dart b/playground/frontend/playground_components/lib/src/controllers/code_runner.dart
@@ -31,17 +31,19 @@ class CodeRunner extends ChangeNotifier {
   SnippetEditingController? snippetEditingController;
 
   CodeRunner({
-    required ValueGetter<SnippetEditingController> snippetEditingController,
+    required ValueGetter<SnippetEditingController>
+        snippetEditingControllerGetter,
     CodeRepository? codeRepository,
   })  : _codeRepository = codeRepository,
-        _snippetEditingControllerGetter = snippetEditingController;
+        _snippetEditingControllerGetter = snippetEditingControllerGetter;
 
   RunCodeResult? _result;
   StreamSubscription<RunCodeResult>? _runSubscription;
   DateTime? _runStartDate;
   DateTime? _runStopDate;
 
-  String? get pipelineOptions => snippetEditingController?.pipelineOptions;
+  String? get pipelineOptions =>
+      _snippetEditingControllerGetter().pipelineOptions;
   RunCodeResult? get result => _result;
   DateTime? get runStartDate => _runStartDate;
   DateTime? get runStopDate => _runStopDate;
@@ -52,7 +54,7 @@ class CodeRunner extends ChangeNotifier {
   String get resultLogOutput => resultLog + resultOutput;
 
   bool get isExampleChanged {
-    return snippetEditingController?.isChanged ?? false;
+    return _snippetEditingControllerGetter().isChanged;
   }
 
   void clearResult() {

diff --git a/playground/frontend/playground_components/lib/src/controllers/playground_controller.dart b/playground/frontend/playground_components/lib/src/controllers/playground_controller.dart
@@ -74,7 +74,7 @@ class PlaygroundController with ChangeNotifier {
 
     codeRunner = CodeRunner(
       codeRepository: codeRepository,
-      snippetEditingController: () => snippetEditingController!,
+      snippetEditingControllerGetter: requireSnippetEditingController,
     )..addListener(notifyListeners);
   }
 

diff --git a/...round/frontend/playground_components/test/src/controllers/playground_controller_test.dart b/...round/frontend/playground_components/test/src/controllers/playground_controller_test.dart
@@ -58,7 +58,6 @@ Future<void> main() async {
     });
 
     test('Initial value of pipelineOptions should be empty string', () {
-      expect(controller.codeRunner.pipelineOptions, null);
       controller.setSdk(Sdk.go);
       expect(controller.codeRunner.pipelineOptions, '');
     });