AVRO-2944: Fix read pointer in java reader to avoid hang on partial read input stream#969
Conversation
5ec9e9b to
298c6fb
Compare
b818968 to
aaa7c77
Compare
|
The CI failure seems unrelated to the change in this PR. For java 11: |
RyanSkraba
left a comment
There was a problem hiding this comment.
LGTM! Good catch, and nice unit test, thanks for the contribution!
|
Hi @RyanSkraba just wondering if this patch could be back-ported to older versions too? We are using Iceberg that still uses Avro 1.9, and Hadoop with Avro 1.7. |
|
Hello! I got caught up taking a look at the build failure -- it's obviously nothing to do with your PR, but I would have liked to see it green. There isn't an official 1.7.x release or even 1.9.3 planned as far as I know. We'd have to bring it up on the mailing list! |
|
@MickJermsurawong can you rebase? The CI has been fixed on master |
aaa7c77 to
7010988
Compare
|
Ah thank you Fokko for the note. Ryan, it's green now. Thank you for the review! |
…ead input stream (apache#969) * Add regression test to show failure before fixing format test * Fix: increment counter with number of bytes read
|
Cherry-picked to branch-1.10! Thanks again for this fix! |
…ead input stream (apache#969) * Add regression test to show failure before fixing format test * Fix: increment counter with number of bytes read
|
@MickJermsurawong / @RyanSkraba I asked a question on the JIRA, curious if this fix could be improved to cover the |
Make sure you have checked all steps below.
Jira
Tests
Commits
Documentation