AVRO-3893: Avoid unnecessary lambda capture on each invocation of 'ObjectCreator.FindType' #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndType' by instead using the key-value passed to the Func<string, Type> lambda from the GetOrAdd invocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The pull request reduces object allocations by removing an unnecessary lambda capture, thus turning a capturing lambda into a non-capturing lambda.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
ObjectCreator.FindType is transitively invoked by many existing unit test, for example tests in 'ObjectCreatorTests' and 'FileTests'.
Documentation
This pull request does not introduce a new feature.