Add NET 7 SDK to Dockerfile #2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@RyanSkraba This might fix your problem. I assume you use the Dockerfile to build and run the tests. The github workflows do not use this dockerfile, and they work as expected, and unfortunately I forgot about that Dockerfile when made the original PR |
RyanSkraba
approved these changes
Apr 20, 2023
Contributor
RyanSkraba
left a comment
RyanSkraba
left a comment
There was a problem hiding this comment.
Thanks so much for the rapid fix!
RyanSkraba
pushed a commit
to RyanSkraba/avro
that referenced
this pull request
Jun 13, 2023
* Add NET 7 SDK to Dockerfile * Update code analyzer package --------- Co-authored-by: Zoltan Csizmadia <[email protected]>
RyanSkraba
pushed a commit
that referenced
this pull request
Jun 14, 2023
* Add NET 7 SDK to Dockerfile * Update code analyzer package --------- Co-authored-by: Zoltan Csizmadia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Installing .NET 7 SDK in the docker image, fixing AVRO-3738.)
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.