Skip to content

Conversation

@akshat0395
Copy link

@akshat0395 akshat0395 commented Apr 6, 2023

(cherry picked from commit 0b17623)

What is the purpose of the change

(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)

Build failure due to wrong version

Verifying this change

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the build label Apr 6, 2023
@github-actions github-actions bot added the Python label Apr 6, 2023
@akshat0395 akshat0395 changed the title Backport AVRO-3715: [Java] plugin-tools-javadoc 3.7.0 does not exist. Backport AVRO-3715: [Java, Python] Fix build issues for branch-1.11 Apr 6, 2023
@akshat0395
Copy link
Author

@nielsbasjes Can you please review this

@RyanSkraba
Copy link
Contributor

Hello! I'm taking a look at this -- thanks so much for identifying the commits!

Other committers: please make sure that you don't squash and merge this -- they should be committed individually! It makes it easier to track the differences between badges.

@akshat0395
Copy link
Author

Thanks @RyanSkraba

@akshat0395
Copy link
Author

Hey @RyanSkraba, did you get some time to check this out?
Really looking forward to get this in.

@RyanSkraba
Copy link
Contributor

Hey -- hello! I've been hard at work getting the list of commits to cherry-pick in place, and they're getting close!

I think we can close this. Some of the cherry-picks are unnecessary (anything to do with github actions, for example), and there's still a bunch missing outside of Java and Python. I'm attempting to do them in branch-1.11 in the same order as they should have been picked on master.

Thanks so much for identifying these! Once we have something closer to a release candidate on branch-1.11, I'll be sure to check in to make sure you're happy with the state!

@RyanSkraba RyanSkraba closed this May 25, 2023
@akshat0395
Copy link
Author

Thanks @RyanSkraba for taking this forward :)

@RyanSkraba
Copy link
Contributor

Just to follow up. #2284 Thanks again -- hopefully this will lead to a 1.11.2 release candidate soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants