AVRO-2943: Add new GenericData String/Utf8 ARRAY comparison test #2137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aromanenko-dev
left a comment
aromanenko-dev
left a comment
There was a problem hiding this comment.
Thanks, I have just one question, ptal
lang/java/avro/src/test/java/org/apache/avro/generic/TestGenericData.java
Outdated
Show resolved
Hide resolved
GenericRecord comparison already handles String vs Utf8 for ARRAY elements. This just adds a unit test to explicitly verify the current correct behaviour. Also renamed GenericData String/Utf8 MAP unit tests which were added on apache#974 to improve clarity on what those tests are actually verifying. https://issues.apache.org/jira/browse/AVRO-2943
frankgrimes97
force-pushed
the
feature/AVRO-2943-equals-array-comparison-string-vs-utf8
branch
from
a397979 to
92cf729
Compare
|
@dkulp could you take a look and merge if there are no objections? |
RyanSkraba
changed the title
RyanSkraba
pushed a commit
to RyanSkraba/avro
that referenced
this pull request
Jun 13, 2023
…ache#2137) GenericRecord comparison already handles String vs Utf8 for ARRAY elements. This just adds a unit test to explicitly verify the current correct behaviour. Also renamed GenericData String/Utf8 MAP unit tests which were added on apache#974 to improve clarity on what those tests are actually verifying. https://issues.apache.org/jira/browse/AVRO-2943
RyanSkraba
pushed a commit
to RyanSkraba/avro
that referenced
this pull request
Jun 14, 2023
…ache#2137) GenericRecord comparison already handles String vs Utf8 for ARRAY elements. This just adds a unit test to explicitly verify the current correct behaviour. Also renamed GenericData String/Utf8 MAP unit tests which were added on apache#974 to improve clarity on what those tests are actually verifying. https://issues.apache.org/jira/browse/AVRO-2943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/AVRO-2943