AVRO-3649: default value for union type should match any type inside the union type. #1932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
approved these changes
Nov 8, 2022
clesaec
force-pushed
the
avro-3649_unionDefaultRust
branch
from
80dce4f to
985c1c7
Compare
Contributor
|
What does "union inside union" mean in the title of this pull request? AFAICT the spec still does not allow unions as members of unions: |
Contributor
Author
|
Yes, title is not good : this means "default (value) for union" is of any type that is "inside union" type (and not only the first). |
clesaec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Part of AVRO-3649 for rust.
PR for java is here
Verifying this change
(Please pick one of the following options)
This change added/updated tests and can be verified as follows:
Documentation