AVRO-3644: [java] Support java.util.Optional in reflect package #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danny02
force-pushed
the
support-of-util-optional
branch
from
bd363e8 to
e4813b4
Compare
martin-g
approved these changes
Oct 18, 2022
Member
martin-g
left a comment
martin-g
left a comment
There was a problem hiding this comment.
I am not very familiar with the Java SDK but the changes look good to me!
Why: Javas Optional type can not be used in any meaningful way with the reflection based schema generation. It is for example not possible to write a generic custom encoding. How does it help with resolving the issue: Optional can be used to make fields null safe in their usage. Side effects: I think that this change should not have any side effects, because Optional fields could not have been used in the past.
Danny02
force-pushed
the
support-of-util-optional
branch
from
e4813b4 to
bd64238
Compare
RyanSkraba
approved these changes
Oct 20, 2022
Contributor
RyanSkraba
left a comment
RyanSkraba
left a comment
There was a problem hiding this comment.
Really nice work! Any thoughts on UNION order for optionals with @AvroDefault as in #1922?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Javas Optional type can not be used in any meaningful way with the reflection-based schema generation. It is for example not possible to write a generic custom encoding.
How does it help with resolving the issue:
Optional can be used to make fields null safe in their usage.
Side effects:
I think that this change should not have any side effects, because Optional fields could not have been used in the past.
What is the purpose of the change
Implementing AVRO-3644.
Verifying this change
Documentation