AVRO-3624: Add apache links #1870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanSkraba
approved these changes
Sep 15, 2022
Contributor
RyanSkraba
left a comment
RyanSkraba
left a comment
There was a problem hiding this comment.
In principle, this LGTM -- the SELECT style is a bit bizarre, but I really have no objection to having someone design-oriented come in and clean it up for us. There's a lot of UX improvements that could be done on the site!
Bear with me while I try and figure out the right way to deploy changes between releases!
Member
|
I will try to re-work the |
Move "ASF links" to the right and render it as a dropdown menu Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Member
Done with b032e71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
*For AVRO-3624 Try to complete site with Apache references to get greener note in https://whimsy.apache.org/site/.
Verifying this change
Manual check :
on folder "doc", run hugo via command
hugo server --buildDrafts --buildFuture --bind 0.0.0.0 --navigateToChangedThis change is only on documentation.
I tried to have somethink that look like "ASF Links" on Apache arrow site, but i succeed only with HTML select/option code, so it's little weird.
Documentation