Skip to content

Conversation

@RyanSkraba
Copy link
Contributor

I picked the Apache Flink style to illustrate -- I like the way that most of the instructions are in the comments and only the essential text is required for the reviewer.

The original: https://github.com/apache/flink/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Jira

Tests

  • does not need testing for this extremely good reason: Non-code change

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added the build label Sep 1, 2022
Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It looks muuuch better than the one before, let a comment to try to make the process simpler.

## Documentation

- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a generic way to say "Javadoc" that includes in-line code documentation like doxygen and python docs?

@RyanSkraba RyanSkraba merged commit e233f2f into apache:master Sep 9, 2022
@RyanSkraba RyanSkraba deleted the rskraba/AVRO-3623-PR-template branch September 9, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants