-
Notifications
You must be signed in to change notification settings - Fork 1.7k
AVRO-3623: Update the PR template #1851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-3623: Update the PR template #1851
Conversation
Co-authored-by: Martin Grigorov <[email protected]>
iemejia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It looks muuuch better than the one before, let a comment to try to make the process simpler.
| ## Documentation | ||
|
|
||
| - Does this pull request introduce a new feature? (yes / no) | ||
| - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a generic way to say "Javadoc" that includes in-line code documentation like doxygen and python docs?
I picked the Apache Flink style to illustrate -- I like the way that most of the instructions are in the comments and only the essential text is required for the reviewer.
The original: https://github.com/apache/flink/blob/master/.github/PULL_REQUEST_TEMPLATE.md
Jira
Tests
Commits
Documentation