Skip to content

Conversation

@martin-g
Copy link
Member

@martin-g martin-g commented Jun 9, 2022

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added the build label Jun 9, 2022
@martin-g martin-g merged commit a8ee877 into master Jun 9, 2022
@martin-g martin-g deleted the avro-3534-enable-dependency-review-action-only-for-prs branch June 9, 2022 21:04
martin-g added a commit that referenced this pull request Jun 23, 2022
…vents (#1717)

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
(cherry picked from commit a8ee877)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant