AVRO-3497 Simplify conditional expression

lang/csharp/src/apache/main/Generic/GenericEnum.cs

@@ -70,10 +70,14 @@ public GenericEnum(EnumSchema schema, string value)
         /// <inheritdoc/>
         public override bool Equals(object obj)
         {
-            if (obj == this) return true;
-            return (obj != null && obj is GenericEnum)
-                ? Value.Equals((obj as GenericEnum).Value, System.StringComparison.Ordinal)
-                : false;
+            if (obj == this)
+            {
+                return true;
+            }
+
+            return obj != null
+                && obj.GetType() == typeof(GenericEnum)
+                && Value.Equals(((GenericEnum)obj).Value, System.StringComparison.Ordinal);
         }
 
         /// <inheritdoc/>

lang/csharp/src/apache/test/Generic/GenericEnumTests.cs

@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using Avro.Generic;
+using NUnit.Framework;
+
+namespace Avro.test.Generic
+{
+    [TestFixture]
+    public class GenericEnumTests
+    {
+        private const string baseSchema = "{\"type\": \"enum\", \"name\": \"Test\", \"symbols\": " +
+            "[\"Unknown\", \"A\", \"B\"], \"default\": \"Unknown\" }";
+
+        [Test]
+        public void TestEquals()
+        {
+            GenericEnum genericEnum = GetBaseGenericEnum();
+            GenericEnum genericEnum2 = GetBaseGenericEnum();
+
+            Assert.IsTrue(genericEnum.Equals(genericEnum2));
+        }
+
+        [Test]
+        public void TestEqualsNotEqual()
+        {
+            GenericEnum genericEnum = GetBaseGenericEnum();
+            GenericEnum genericEnum2 = new GenericEnum(Schema.Parse(baseSchema) as EnumSchema, "B");
+
+            Assert.IsFalse(genericEnum.Equals(genericEnum2));
+        }
+
+        [Test]
+        public void TestEqualsObject()
+        {
+            GenericEnum genericEnum = GetBaseGenericEnum();
+            object genericEnum2 = genericEnum;
+
+            Assert.IsTrue(genericEnum.Equals(genericEnum2));
+        }
+
+        [Test]
+        public void TestEqualsObjectNotEqual()
+        {
+            GenericEnum genericEnum = GetBaseGenericEnum();
+            GenericEnum genericEnum2 = new GenericEnum(Schema.Parse(baseSchema) as EnumSchema, "B");
+
+            Assert.IsFalse(genericEnum.Equals((object)genericEnum2));
+        }
+
+        [Test]
+        public void TestEqualsObjectNullObject()
+        {
+            GenericEnum genericEnum = GetBaseGenericEnum();
+
+            Assert.IsFalse(genericEnum.Equals((object)null));
+        }
+
+        private GenericEnum GetBaseGenericEnum()
+        {
+            GenericEnum genericEnum = new GenericEnum(Schema.Parse(baseSchema) as EnumSchema, "A");
+
+            return genericEnum;
+        }
+    }
+}