Skip to content

AVRO-3494: Uncomment a test for recursive types #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-g merged 1 commit into from
Apr 18, 2022
Merged

AVRO-3494: Uncomment a test for recursive types #1648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions lang/rust/avro/tests/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,12 +565,6 @@ lazy_static! {
EXAMPLES.iter().copied().filter(|s| s.1).collect();
}

/*
// TODO: (#92) properly support recursive types and uncomment

This test is failing unwrapping the outer schema with ParseSchemaError("Unknown type: X"). It seems
that recursive types are not properly supported.

#[test]
fn test_correct_recursive_extraction() {
init();
Expand All @@ -594,21 +588,31 @@ fn test_correct_recursive_extraction() {
]
}"#;
let outer_schema = Schema::parse_str(raw_outer_schema).unwrap();
if let Schema::Record { fields: outer_fields, .. } = outer_schema {
let raw_inner_schema = outer_fields[0].schema.canonical_form();
let inner_schema = Schema::parse_str(raw_inner_schema.as_str()).unwrap();
if let Schema::Record { fields: inner_fields, .. } = inner_schema {
if let Schema::Record {name: recursive_type, .. } = &inner_fields[0].schema {
if let Schema::Record {
fields: outer_fields,
..
} = outer_schema
{
let inner_schema = &outer_fields[0].schema;
if let Schema::Record {
fields: inner_fields,
..
} = inner_schema
{
if let Schema::Record {
name: recursive_type,
..
} = &inner_fields[0].schema
{
assert_eq!("X", recursive_type.name.as_str());
}
} else {
panic!("inner schema {} should have been a record", raw_inner_schema)
panic!("inner schema {:?} should have been a record", inner_schema)
}
} else {
panic!("outer schema {} should have been a record", raw_outer_schema)
panic!("outer schema {:?} should have been a record", outer_schema)
}
}
*/

#[test]
fn test_parse() {
Expand Down