Preparing for 1.12.0-SNAPSHOT #1356
Conversation
| "version": "1.12.0-SNAPSHOT", | ||
| "lockfileVersion": 1, | ||
| "requires": true, | ||
| "packages": { |
There was a problem hiding this comment.
Is this change related to this PR ?
There was a problem hiding this comment.
This is kind of tricky! We bumped lockfileVersion to 2, which seemed like the right thing to do, but since build/release process uses the oldest supported version of Node.js, this file is always updated after a build. That doesn't seem right to me either, so I checked in the file created "using the tools at time of bump".
What do you think? What's the right thing to do for a node.js developer?
There was a problem hiding this comment.
For me the best is to use exact versions in package.json for [dev] dependencies, like 0.11.0.
Using "smart" versions like ~0.11.0 or ^0.11.0 leads to such kind of problems. See https://nodejs.dev/learn/the-package-lock-json-file for more.
I think it is OK to merge this PR now, but maybe we should pin the dependencies' versions for 1.12.0 ?!
There was a problem hiding this comment.
Effectively, I'm going to merge this now so that all the commits after it are "visibly" 1.12.0 and require cherry-picking if we want them on branch-1.11! Thanks for the review!
2 participants
Bumps master to the next major release.