This repository has been archived by the owner on May 12, 2021. It is now read-only.
Feature add docker/volume and volume/secret support (#58) #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Testing Done:
This patch was originally applied to
rel/0.21.0
and has been updated to apply to the current master branch. In the form applied torel/0.21.0
it has been running in my production environments since December 2018.As far as how to test the new features.
docker/volume
I have dvdcli-0.2.0. I run rexray for EBS support. The mesos-agent uses AWS IAM to describe/attach/detach/etc EBS volumes.
volume/secret
This is a little more interesting to test. I'm not aware of any publicly available secret resolver implementations. At minimum you have to write your own secret resolver. We chose to target with
hashicorp/vault
and implent a kv2 resolver.