ARROW-12202: [Rust] WIP Fix SEGFAULT/ SIGILL in child-data ffi #9887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
changed the title
pitrou
reviewed
Apr 6, 2021
| // For child data a non null string is expected and is called item | ||
| // TODO: get the field name for general nested data | ||
| // For List child data a non null string is expected and is called item | ||
| name: CString::new("item").unwrap().into_raw(), |
Member
There was a problem hiding this comment.
This should be released in release_schema, like format already is.
pitrou
reviewed
Apr 6, 2021
rust/arrow/src/ffi.rs
Outdated
| // release children | ||
| for i in 0..array.n_children { | ||
| let child = *array.children.add(i as usize); | ||
| release_array(child); |
Member
There was a problem hiding this comment.
You should call the release callback stored on child, not release_array directly.
Member
There was a problem hiding this comment.
Note you must do the same thing in release_schema as well.
Contributor
|
The Apache Arrow Rust community is moving the Rust implementation into its own dedicated github repositories arrow-rs and arrow-datafusion. It is likely we will not merge this PR into this repository Please see the mailing-list thread for more details We expect the process to take a few days and will follow up with a migration plan for the in-flight PRs. |
Contributor
|
Reopened at apache/arrow-rs#21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue #9778