Skip to content

ARROW-11908: [C++] Work around flaky integration by retrying #9755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lidavidm wants to merge 1 commit into from
Closed

ARROW-11908: [C++] Work around flaky integration by retrying #9755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions cpp/src/arrow/flight/test_integration_client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@
// client then requests the data from the server and compares it to
// the data originally uploaded.

#include <chrono>
#include <iostream>
#include <memory>
#include <string>
#include <thread>

#include <gflags/gflags.h>

Expand Down Expand Up @@ -202,6 +204,19 @@ class IntegrationTestScenario : public flight::Scenario {
} // namespace flight
} // namespace arrow

constexpr int kRetries = 3;

arrow::Status RunScenario(arrow::flight::Scenario* scenario) {
auto options = arrow::flight::FlightClientOptions::Defaults();
std::unique_ptr<arrow::flight::FlightClient> client;

RETURN_NOT_OK(scenario->MakeClient(&options));
arrow::flight::Location location;
RETURN_NOT_OK(arrow::flight::Location::ForGrpcTcp(FLAGS_host, FLAGS_port, &location));
RETURN_NOT_OK(arrow::flight::FlightClient::Connect(location, options, &client));
return scenario->RunClient(std::move(client));
}

int main(int argc, char** argv) {
arrow::util::ArrowLog::InstallFailureSignalHandler();

Expand All @@ -214,16 +229,15 @@ int main(int argc, char** argv) {
scenario = std::make_shared<arrow::flight::IntegrationTestScenario>();
}

arrow::flight::FlightClientOptions options =
arrow::flight::FlightClientOptions::Defaults();
std::unique_ptr<arrow::flight::FlightClient> client;

ABORT_NOT_OK(scenario->MakeClient(&options));

arrow::flight::Location location;
ABORT_NOT_OK(arrow::flight::Location::ForGrpcTcp(FLAGS_host, FLAGS_port, &location));
ABORT_NOT_OK(arrow::flight::FlightClient::Connect(location, options, &client));
ABORT_NOT_OK(scenario->RunClient(std::move(client)));
// ARROW-11908: retry a few times in case a client is slow to bring up the server
auto status = arrow::Status::OK();
for (int i = 0; i < kRetries; i++) {
status = RunScenario(scenario.get());
if (status.ok()) break;
// Failed, wait a bit and try again
std::this_thread::sleep_for(std::chrono::milliseconds((i + 1) * 500));
}
ABORT_NOT_OK(status);

arrow::util::ArrowLog::UninstallSignalAction();
return 0;
Expand Down