-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-11894: [Rust][DataFusion] Change flight server example to use DataFrame API #9645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-11894: [Rust][DataFusion] Change flight server example to use DataFrame API #9645
Conversation
|
BTW the test workspace check is also failing on master, so it may not be related to this PR. See more details on https://issues.apache.org/jira/browse/ARROW-11896 |
|
FYI I merged #9653 / ARROW-11896 for the Rust CI checks which may affect this PR. If you see "Rust / AMD64 Debian 10 Rust stable test workspace" failing with a linker error or no logs, rebasing against master will hopefully fix the problem |
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a nice cleanup @Dandandan thank you. I don't think this code is tested as part of CI link so I would like someone to test it locally before merging -- I'll do so either later today or tomorrow if no one else gets around to it
21c7c01 to
b86061b
Compare
Codecov Report
@@ Coverage Diff @@
## master #9645 +/- ##
==========================================
- Coverage 82.49% 82.43% -0.07%
==========================================
Files 245 245
Lines 57347 57643 +296
==========================================
+ Hits 47311 47517 +206
- Misses 10036 10126 +90
Continue to review full report at Codecov.
|
|
I tried to retrigger the jobs on this PR as I think |
| let schema_flight_data = | ||
| arrow_flight::utils::flight_data_from_arrow_schema( | ||
| schema.as_ref(), | ||
| &df.schema().clone().into(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ -- looks great @Dandandan
Before this PR, it uses the logical plan / optimization / physical plan more directly.
As it is meant as example, I think it's better to use the more higher level
sqlandcollectfunctions.Also, some misc cleanup.