Skip to content

Conversation

@Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Mar 6, 2021

Before this PR, it uses the logical plan / optimization / physical plan more directly.
As it is meant as example, I think it's better to use the more higher level sql and collect functions.

Also, some misc cleanup.

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

@kou kou changed the title ARROW-11894: Change flight server example to use DataFrame API ARROW-11894: [Rust][DataFusion] Change flight server example to use DataFrame API Mar 6, 2021
@alamb
Copy link
Contributor

alamb commented Mar 7, 2021

BTW the test workspace check is also failing on master, so it may not be related to this PR. See more details on https://issues.apache.org/jira/browse/ARROW-11896

@alamb
Copy link
Contributor

alamb commented Mar 7, 2021

FYI I merged #9653 / ARROW-11896 for the Rust CI checks which may affect this PR. If you see "Rust / AMD64 Debian 10 Rust stable test workspace" failing with a linker error or no logs, rebasing against master will hopefully fix the problem

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a nice cleanup @Dandandan thank you. I don't think this code is tested as part of CI link so I would like someone to test it locally before merging -- I'll do so either later today or tomorrow if no one else gets around to it

@Dandandan Dandandan force-pushed the flight_server_dataframe_example branch from 21c7c01 to b86061b Compare March 7, 2021 21:41
@codecov-io
Copy link

Codecov Report

Merging #9645 (b86061b) into master (bfa99d9) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9645      +/-   ##
==========================================
- Coverage   82.49%   82.43%   -0.07%     
==========================================
  Files         245      245              
  Lines       57347    57643     +296     
==========================================
+ Hits        47311    47517     +206     
- Misses      10036    10126      +90     
Impacted Files Coverage Δ
rust/datafusion/examples/flight_server.rs 0.00% <0.00%> (ø)
rust/parquet/src/basic.rs 87.22% <0.00%> (-10.04%) ⬇️
rust/parquet/src/arrow/array_reader.rs 77.53% <0.00%> (-0.08%) ⬇️
rust/parquet/src/schema/parser.rs 90.20% <0.00%> (ø)
rust/parquet/src/file/footer.rs 96.26% <0.00%> (+0.03%) ⬆️
rust/parquet/src/file/writer.rs 95.32% <0.00%> (+0.21%) ⬆️
rust/parquet/src/schema/types.rs 89.79% <0.00%> (+0.25%) ⬆️
rust/parquet/src/file/metadata.rs 92.96% <0.00%> (+0.74%) ⬆️
rust/arrow/src/array/equal/utils.rs 76.47% <0.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfa99d9...b86061b. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented Mar 8, 2021

I tried to retrigger the jobs on this PR as I think integration is failing due to https://issues.apache.org/jira/browse/ARROW-11908

let schema_flight_data =
arrow_flight::utils::flight_data_from_arrow_schema(
schema.as_ref(),
&df.schema().clone().into(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ -- looks great @Dandandan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants