ARROW-11662: [C++] Support sorting decimal and fixed size binary data #9577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also enable nth_to_indices on decimal and fixed size binary data.
pitrou
force-pushed
the
ARROW-11662-sort-decimal
branch
from
518f0f8 to
cbdbba5
Compare
bkietz
approved these changes
Feb 26, 2021
| bool IsNull() const { return array->IsNull(index); } | ||
|
|
||
| ViewType GetView() const { return array->GetView(index); } | ||
| LogicalValueType Value() const { return V::LogicalValue(array->GetView(index)); } |
Member
There was a problem hiding this comment.
We need to refactor/rename GetViewType, this was very confusing to read (not in any way that's your fault)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enable nth_to_indices on decimal and fixed size binary data.