-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-11779: [Rust] make alloc module public #9572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nevi-me
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably an omission, the intention was to keep alloc public as memory was.
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritchie46 I am curious what your use case for using the allocator module directly is? It seems like the main public interface for Arrow aspires to a higher level (Array et al).
|
I use an wrapper type that is basically a Rust It is used for instance in FromIterator to build a When I don't have null values or I can just use an existing null buffer the |
|
Thanks @ritchie46 -- the idea of I wonder if it would make sense to consider move |
|
I do think that an To my knowledge, the |
@ritchie46 I would enjoy helping review that code as well as I spent some time reviewing [`ChunkedArray])(https://github.com/ritchie46/polars/blob/6f2dfd43dbf7ab44cbd2904af57d3441a1b52853/polars/polars-core/src/chunked_array/mod.rs#L141-L157) and it looks very useful for something in IOx (the ingest path). Thank you for the pointers (and the well commented code) |
Polars uses the
arrow::memorymodule. With the backwards incompatible change of #9495, the API is refactored toarrow::alloc.By making
allocpublic, users can shift to the new changes.