Skip to content

ARROW-11756: [R] passing a partition as a schema leads to segfaults #9566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pachadotdev wants to merge 7 commits into from
Closed

ARROW-11756: [R] passing a partition as a schema leads to segfaults #9566

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1f2f0ce
ARROW-11756: [R] passing a partition as a schema leads to segfaults
Feb 24, 2021
fed2fd8
https://github.com/apache/arrow/pull/9566#discussion_r582365632
Feb 24, 2021
49c836b
https://github.com/apache/arrow/pull/9566#discussion_r582392410
Feb 25, 2021
efc83db
https://github.com/apache/arrow/pull/9566#discussion_r582407117
Feb 25, 2021
a11cc84
https://github.com/apache/arrow/pull/9566#discussion_r582406620
Feb 25, 2021
e02d499
https://github.com/apache/arrow/pull/9566#discussion_r582406082
Feb 25, 2021
9b3ac8b
https://github.com/apache/arrow/pull/9566#discussion_r582471496
Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions r/R/dataset.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ open_dataset <- function(sources,
partitioning = hive_partition(),
unify_schemas = NULL,
...) {
if (isFALSE(inherits(schema, "Schema")) && isFALSE(is.null(schema))) {
stop("'schema' must be a Schema object", call. = FALSE)
}
Comment thread
pachadotdev marked this conversation as resolved.
Outdated
Comment thread
pachadotdev marked this conversation as resolved.
Outdated
if (is_list_of(sources, "Dataset")) {
if (is.null(schema)) {
if (is.null(unify_schemas) || isTRUE(unify_schemas)) {
Expand Down
32 changes: 32 additions & 0 deletions r/tests/testthat/test-dataset.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,38 @@ test_that("Hive partitioning", {
)
})

test_that("open_dataset fails when partitioning is passed as schema", {
Comment thread
pachadotdev marked this conversation as resolved.
Outdated
expect_error(
open_dataset(hive_dir, hive_partition(other = utf8(), group = uint8()))
)

# skipping schema
ds <- open_dataset(hive_dir, , hive_partition(other = utf8(), group = uint8()))
Comment thread
pachadotdev marked this conversation as resolved.
Outdated
expect_is(ds, "Dataset")
expect_equivalent(
ds %>%
filter(group == 2) %>%
select(chr, dbl) %>%
filter(dbl > 7 & dbl < 53) %>%
collect() %>%
arrange(dbl),
df2[1:2, c("chr", "dbl")]
)

# and again with explicit argument
ds <- open_dataset(hive_dir, partitioning = hive_partition(other = utf8(), group = uint8()))
expect_is(ds, "Dataset")
expect_equivalent(
ds %>%
filter(group == 2) %>%
select(chr, dbl) %>%
filter(dbl > 7 & dbl < 53) %>%
collect() %>%
arrange(dbl),
df2[1:2, c("chr", "dbl")]
)
})

test_that("Partitioning inference", {
# These are the same tests as above, just using the *PartitioningFactory
ds1 <- open_dataset(dataset_dir, partitioning = "part")
Expand Down