Skip to content

Conversation

@houqp
Copy link
Member

@houqp houqp commented Feb 20, 2021

This patch set makes it possible for downstream application to do schema inference with IOs other than local filesystem.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a no op.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good catch.

@github-actions
Copy link

@codecov-io
Copy link

codecov-io commented Feb 20, 2021

Codecov Report

Merging #9534 (e3312f2) into master (35daca2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9534   +/-   ##
=======================================
  Coverage   82.32%   82.32%           
=======================================
  Files         245      245           
  Lines       56412    56414    +2     
=======================================
+ Hits        46442    46445    +3     
+ Misses       9970     9969    -1     
Impacted Files Coverage Δ
rust/arrow/src/csv/reader.rs 93.17% <100.00%> (+0.02%) ⬆️
rust/parquet/src/encodings/encoding.rs 95.05% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35daca2...e3312f2. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks @houqp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good catch.

@alamb
Copy link
Contributor

alamb commented Feb 26, 2021

@houqp / @nevi-me is this PR ready to go? It looks good to me. I'll plan to merge it tomorrow if I don't hear anything otherwise

@nevi-me
Copy link
Contributor

nevi-me commented Feb 26, 2021

@houqp / @nevi-me is this PR ready to go? It looks good to me. I'll plan to merge it tomorrow if I don't hear anything otherwise

I was going to wait for #9534 (comment)

@alamb
Copy link
Contributor

alamb commented Feb 26, 2021

Makes sense @nevi-me -- sorry I was getting lost with the comment threads. Thank you

@houqp
Copy link
Member Author

houqp commented Feb 28, 2021

alright, pushed reader offset rewind fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants