-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-11707: [Rust] support CSV schema inference without file IO #9534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rust/arrow/src/csv/reader.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a no op.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good catch.
Codecov Report
@@ Coverage Diff @@
## master #9534 +/- ##
=======================================
Coverage 82.32% 82.32%
=======================================
Files 245 245
Lines 56412 56414 +2
=======================================
+ Hits 46442 46445 +3
+ Misses 9970 9969 -1
Continue to review full report at Codecov.
|
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- thanks @houqp
rust/arrow/src/csv/reader.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good catch.
I was going to wait for #9534 (comment) |
|
Makes sense @nevi-me -- sorry I was getting lost with the comment threads. Thank you |
|
alright, pushed reader offset rewind fix. |
This patch set makes it possible for downstream application to do schema inference with IOs other than local filesystem.