ARROW-11692: [Rust][DataFusion] Improve OptimizerRule comments#9529
Closed
alamb wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-11692: [Rust][DataFusion] Improve OptimizerRule comments#9529alamb wants to merge 3 commits intoapache:masterfrom
alamb wants to merge 3 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9529 +/- ##
==========================================
+ Coverage 82.24% 82.27% +0.03%
==========================================
Files 244 244
Lines 55289 55371 +82
==========================================
+ Hits 45470 45555 +85
+ Misses 9819 9816 -3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am messing around with
OptimizerRulefor some experiments, and found myself clarifying the comments each time... So I figured I would at least get the doc changes queued for inclusion