Skip to content

Conversation

@trucnguyenlam
Copy link

Hi,

I am making a PR following the discussion in ARROW-11497

This is my first PR to this project, please let me know if I'm missing something, I will try to address all problem as much as I can.

Cheers,
Truc

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@trucnguyenlam trucnguyenlam changed the title Provide parquet enable compliant nested type flag ARROW-11497: [Python] Provide parquet enable compliant nested type flag for python binding Feb 13, 2021
@github-actions
Copy link

@emkornfield
Copy link
Contributor

@trucnguyenlam thank you for the PR it looks like the CI failure is legitimate here.

Otherwise looks good to me

CC @jorisvandenbossche for python/cython style check

@trucnguyenlam
Copy link
Author

@emkornfield thanks for your comment, I've also resolved python/cython style check, hopefully this should be good enough to be merged.

@jorgecarleitao jorgecarleitao force-pushed the master branch 2 times, most recently from d4608a9 to 356c300 Compare February 14, 2021 12:09
@trucnguyenlam
Copy link
Author

@emkornfield @jorisvandenbossche Is it ok to be merged now? thanks

@jorisvandenbossche
Copy link
Member

@trucnguyenlam it seems you have some unrelated changes included (some git problem I suppose). Can you rebase this on master?

@trucnguyenlam
Copy link
Author

trucnguyenlam commented Feb 19, 2021

@jorisvandenbossche done rebase and expanded doc, please have a look if it is ok to merge

@trucnguyenlam
Copy link
Author

@jorisvandenbossche please have a look if it is ok to merge? I resolved all issues as far as I know.

@trucnguyenlam
Copy link
Author

@jorisvandenbossche could you please have a look at the PR? cheers

@trucnguyenlam
Copy link
Author

@jorisvandenbossche @emkornfield this is open for quite some time, please have a look if this is eligible to be merged, thanks

@emkornfield
Copy link
Contributor

+1, going to merge, we can address any items as a followup. @trucnguyenlam apologies for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants