ARROW-11602: [Rust] Clippy lints #9475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
|
Thank you @nevi-me -- looks like there are still a few more lints being hit |
alamb
approved these changes
Feb 11, 2021
|
Looks to me like Rust 1.50 was released today: https://forge.rust-lang.org/
So clippy got pickier perhaps |
|
darn it, I was hoping it isn't a new stable release, because we have a lot of unnecessary |
|
@nevi-me -- I am working on a fix for the other lint errors based on this PR. My plan is to just disable the lints that are still failing -- because as you say changing |
|
Thanks @alamb, it's inefficient use of time to try pursue all the lints now. Thanks, I'm closing this. |
jorgecarleitao
pushed a commit
that referenced
this pull request
Feb 11, 2021
# Rationale: CI uses "stable" rust. 1.50 stable was released today: https://blog.rust-lang.org/2021/02/11/Rust-1.50.0.html The new clippy is pickier resulting in many clippy warnings such as https://github.com/apache/arrow/pull/9469/checks?check_run_id=1881854256 We need to get CI back green # Changes Based on based on #9475 from @nevi-me, this PR aims to get the CI green as soon as possible. Ideally, we would fix the actual lint problems, However, when I tried to do so the lints propagated into a significant change -- as clippy says to remove the `Result` but then there are a bunch of call sites that then also need t be changed I want to get CI back clean as soon as possible so I just hammered through and cleaned up as best I could as well as sprinkling in various `#[allow(clippy::unnecessary_wraps)]` as necessary to get a clean run. My rationale is that the code is no worse than it was before. Though it could be better! Closes #9476 from alamb/ARROW-11602-lints Authored-by: Neville Dipale <[email protected]> Signed-off-by: Jorge C. Leitao <[email protected]>
sgnkc
pushed a commit
to sgnkc/arrow
that referenced
this pull request
Feb 17, 2021
# Rationale: CI uses "stable" rust. 1.50 stable was released today: https://blog.rust-lang.org/2021/02/11/Rust-1.50.0.html The new clippy is pickier resulting in many clippy warnings such as https://github.com/apache/arrow/pull/9469/checks?check_run_id=1881854256 We need to get CI back green # Changes Based on based on apache#9475 from @nevi-me, this PR aims to get the CI green as soon as possible. Ideally, we would fix the actual lint problems, However, when I tried to do so the lints propagated into a significant change -- as clippy says to remove the `Result` but then there are a bunch of call sites that then also need t be changed I want to get CI back clean as soon as possible so I just hammered through and cleaned up as best I could as well as sprinkling in various `#[allow(clippy::unnecessary_wraps)]` as necessary to get a clean run. My rationale is that the code is no worse than it was before. Though it could be better! Closes apache#9476 from alamb/ARROW-11602-lints Authored-by: Neville Dipale <[email protected]> Signed-off-by: Jorge C. Leitao <[email protected]>
alamb
pushed a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
# Rationale: CI uses "stable" rust. 1.50 stable was released today: https://blog.rust-lang.org/2021/02/11/Rust-1.50.0.html The new clippy is pickier resulting in many clippy warnings such as https://github.com/apache/arrow/pull/9469/checks?check_run_id=1881854256 We need to get CI back green # Changes Based on based on apache/arrow#9475 from @nevi-me, this PR aims to get the CI green as soon as possible. Ideally, we would fix the actual lint problems, However, when I tried to do so the lints propagated into a significant change -- as clippy says to remove the `Result` but then there are a bunch of call sites that then also need t be changed I want to get CI back clean as soon as possible so I just hammered through and cleaned up as best I could as well as sprinkling in various `#[allow(clippy::unnecessary_wraps)]` as necessary to get a clean run. My rationale is that the code is no worse than it was before. Though it could be better! Closes #9476 from alamb/ARROW-11602-lints Authored-by: Neville Dipale <[email protected]> Signed-off-by: Jorge C. Leitao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some clippy lints that are returning errors, where they haven't before. Not sure what's happening, as we've pinned versions.