Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Feb 3, 2021

The tests use "gold" files generated by PyArrow 2.0.0 and are only enabled for C++.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andygrove This seems to be some automated style that got applied when running archery docker conda-integration. Is it ok?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit of an irritant because there's a slight difference in the behaviour of the formatter in the stable vs nightly versions.
We can leave it as is on this PR. I'll make time to look into a solution.

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

@emkornfield
Copy link
Contributor

LGTM, I can't comment on JS or Rust changes. I think in the long run we'll also want proper on-demand integration tests but this is a good start.

The tests use "gold" files generated by PyArrow 2.0.0 and are only enabled for C++.
@pitrou pitrou force-pushed the ARROW-11417-compression-integration branch from ad80219 to d631204 Compare February 9, 2021 17:36
@codecov-io
Copy link

Codecov Report

Merging #9408 (d631204) into master (599a63e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9408      +/-   ##
==========================================
- Coverage   82.09%   82.09%   -0.01%     
==========================================
  Files         233      233              
  Lines       54375    54375              
==========================================
- Hits        44639    44637       -2     
- Misses       9736     9738       +2     
Impacted Files Coverage Δ
rust/arrow-flight/src/arrow.flight.protocol.rs 0.00% <ø> (ø)
rust/parquet/src/encodings/encoding.rs 94.67% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 599a63e...d631204. Read the comment docs.

@pitrou pitrou closed this in 0a435f4 Feb 9, 2021
@pitrou pitrou deleted the ARROW-11417-compression-integration branch February 9, 2021 18:13
sgnkc pushed a commit to sgnkc/arrow that referenced this pull request Feb 17, 2021
The tests use "gold" files generated by PyArrow 2.0.0 and are only enabled for C++.

Closes apache#9408 from pitrou/ARROW-11417-compression-integration

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants