Skip to content

ARROW-11332: [Rust] Use MutableBuffer in take_string instead of Vec #9279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dandandan wants to merge 1 commit into from
Closed

ARROW-11332: [Rust] Use MutableBuffer in take_string instead of Vec #9279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rust/arrow/src/compute/kernels/take.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ where
let mut offsets_buffer = MutableBuffer::from_len_zeroed(bytes_offset);

let offsets = offsets_buffer.typed_data_mut();
let mut values = Vec::with_capacity(bytes_offset);
let mut values = MutableBuffer::new(0);
Copy link
Contributor Author

@Dandandan Dandandan Jan 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used to be here bytes_offset but that doesn't make a lot of sense.
The values array could be empty as well (e.g. for empty strings), or have a totally different capacity.

let mut length_so_far = OffsetSize::zero();
offsets[0] = length_so_far;

Expand Down Expand Up @@ -513,7 +513,7 @@ where
let mut data = ArrayData::builder(<OffsetSize as StringOffsetSizeTrait>::DATA_TYPE)
.len(data_len)
.add_buffer(offsets_buffer.into())
.add_buffer(Buffer::from(values));
.add_buffer(values.into());
if let Some(null_buffer) = nulls {
data = data.null_bit_buffer(null_buffer);
}
Expand Down