Skip to content

ARROW-11086: [Rust] Extend take implementation to more index types #9057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dandandan wants to merge 2 commits into from
Closed

ARROW-11086: [Rust] Extend take implementation to more index types #9057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e93f29b
Extend take implementation to more index types
Dandandan Dec 31, 2020
571bd65
Specify type after collect
Dandandan Dec 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions rust/arrow/src/compute/kernels/take.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,16 @@ macro_rules! downcast_dict_take {
/// # Ok(())
/// # }
/// ```
pub fn take(
pub fn take<IndexType>(
values: &Array,
indices: &UInt32Array,
indices: &PrimitiveArray<IndexType>,
options: Option<TakeOptions>,
) -> Result<ArrayRef> {
take_impl::<UInt32Type>(values, indices, options)
) -> Result<ArrayRef>
where
IndexType: ArrowNumericType,
IndexType::Native: ToPrimitive,
{
take_impl(values, indices, options)
}

fn take_impl<IndexType>(
Expand Down
3 changes: 2 additions & 1 deletion rust/datafusion/src/physical_plan/hash_join.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ fn build_batch_from_indices(
// 2. based on the pick, `take` items from the different recordBatches
let mut columns: Vec<Arc<dyn Array>> = Vec::with_capacity(schema.fields().len());

let right_indices = indices.iter().map(|(_, join_index)| join_index).collect();
let right_indices: UInt32Array =
indices.iter().map(|(_, join_index)| join_index).collect();

for field in schema.fields() {
// pick the column (left or right) based on the field name.
Expand Down