Skip to content

Conversation

@huitseeker
Copy link
Contributor

Cleans some TOML fields and marks some testing crates not-for-publication.

@github-actions
Copy link

@huitseeker huitseeker force-pushed the publication branch 2 times, most recently from 2406448 to b519716 Compare December 28, 2020 18:17
@andygrove
Copy link
Member

@huitseeker Unfortunately the release verification scripts will need updating to reflect the changes to these Cargo.toml files. If you look at the CI failure you should be able to reproduce this locally by running the same script.

@nevi-me
Copy link
Contributor

nevi-me commented Jan 6, 2021

I'll complete this during the week

@huitseeker
Copy link
Contributor Author

@nevi-me @andygrove The release verification component should now be fixed. Besides that, some integration tests seem to be running on the wrong side of a source incompatible change (e.g. the same compilation errors are met in the unrelated #9137). Those failures should probably be addressed in a distinct PR?

@nevi-me
Copy link
Contributor

nevi-me commented Jan 9, 2021

Hey @huitseeker, the errors in integration tests should be fixed now, may you please kindly rebase

Copy link
Contributor

@paddyhoran paddyhoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants